Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the TAP doctest in dal/index.rst. #565

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

msdemlei
Copy link
Contributor

@msdemlei msdemlei commented Jun 27, 2024

The TOP 10 * that used to be in the query is highly dependent on the state of the remote machine, so it's a miracle it worked as well as it did.

The query I am using now should be stable for the forseeable future (CALIFA is done).

I have, for now, dropped the example for getdataobj(). The output of that is extremely opaque, and I'm not sure I'm a big fan of that method in the first place. If we show it, we have to say something about what the intended use is -- in this case, this could be a brief excursion into datalink (retrieving a #preview, perhaps?), but I'd say that's for another day.

closes #564

The TOP 10 * that used to be in the query is highly dependent on the state
of the remote machine, so it's a miracle it worked as well as it did.

The query I am using now should be stable for the forseeable future (CALIFA
is done).

I have, for now, dropped the example for getdataobj().  The output of that is
extremely opaque, and I'm not sure I'm a big fan of that method in the first
place.  *If* we show it, we have to say something about what the intended use
is -- in this case, this could be a brief excursion into datalink (retrieving
a #preview, perhaps?), but I'd say that's for another day.
@msdemlei msdemlei force-pushed the stabilise-dal-index-doctests branch from b7930da to 5d69a6b Compare June 27, 2024 05:28
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bsipocz bsipocz merged commit a993527 into astropy:main Jun 27, 2024
10 checks passed
bsipocz added a commit that referenced this pull request Oct 14, 2024
Fixing the TAP doctest in dal/index.rst.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants