BUG: fix keyword arguments #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
added
bug
component: dal
Affects-dev
|
cc @msdemlei - while I was fixing keyword argument stuff, I added the modifications you asked for SIAv1 in #512 (comment) |
|
And now this also includes a skip for the flaky doctest that is unrelated and what we also see in the other PRs. |
andamian
approved these changes
Jun 27, 2024
|
Thanks. Let me remove the last commit before merging, as it has been fixed separately and better in a recent PR. |
bsipocz
force-pushed
the
MAINT_datalink_keyword_api
branch
from
7c2bec3 to
3d84602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #507, apparently this part of the code is not covered by tests, but it is used in astroquery's remote test suite, thus I caught it before we landed a release.