Skip to content

Commit

Permalink
Making new iter_datalinks_from_x methods private.
Browse files Browse the repository at this point in the history
This is on review comments by @bsipocz and @andamian.
  • Loading branch information
msdemlei committed Sep 25, 2024
1 parent cbe2490 commit 9dbd2db
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pyvo/dal/adhoc.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class DatalinkResultsMixin(AdhocServiceResultsMixin):
"""
Mixin for datalink functionallity for results classes.
"""
def iter_datalinks_from_dlblock(self, datalink_service):
def _iter_datalinks_from_dlblock(self, datalink_service):
"""yields datalinks from the current rows using a datalink
service RESOURCE.
"""
Expand Down Expand Up @@ -259,7 +259,7 @@ def _guess_access_url(row):
if access_url:
return access_url

Check warning on line 260 in pyvo/dal/adhoc.py

View check run for this annotation

Codecov / codecov/patch

pyvo/dal/adhoc.py#L258-L260

Added lines #L258 - L260 were not covered by tests

def iter_datalinks_from_product_rows(self):
def _iter_datalinks_from_product_rows(self):
"""yield datalinks from self's rows if they describe datalink-valued
products.
"""
Expand Down Expand Up @@ -291,10 +291,10 @@ def iter_datalinks(self):
self._datalink = None

if self._datalink is None:
yield from self.iter_datalinks_from_product_rows()
yield from self._iter_datalinks_from_product_rows()

else:
yield from self.iter_datalinks_from_dlblock(self._datalink)
yield from self._iter_datalinks_from_dlblock(self._datalink)


class DatalinkRecordMixin:
Expand Down

0 comments on commit 9dbd2db

Please sign in to comment.