Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a naive sparse histogram. #534

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Use a naive sparse histogram. #534

merged 3 commits into from
Jan 6, 2025

Conversation

delucchi-cmu
Copy link
Contributor

We really just need the non-zero indexes and non-zero values, and the complexity of the general scipy sparse array is adding a lot of compute overhead, both in the perform_write call, and when aggregating histograms for the point_map.fits file.

Requires astronomy-commons/hats#446

Copy link

github-actions bot commented Dec 20, 2024

Before [c8082b6] After [5819625] Ratio Benchmark (Parameter)
12.5±0.02s 12.7±0.03s 1.02 benchmarks.time_create_large_catalog
14.7±0.2ms 14.8±0.3ms 1.01 benchmarks.time_box_filter_on_partition
1.85±0.02s 1.86±0.01s 1.01 benchmarks.time_create_midsize_catalog
29.6±0.6ms 29.9±0.5ms 1.01 benchmarks.time_polygon_search
86.6±1ms 86.8±1ms 1 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (c8082b6) to head (37e3554).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   97.38%   97.38%   -0.01%     
==========================================
  Files          43       43              
  Lines        1720     1719       -1     
==========================================
- Hits         1675     1674       -1     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 965ef8f into main Jan 6, 2025
11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/import/453 branch January 6, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants