Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting to search filters #524

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add plotting to search filters #524

merged 3 commits into from
Dec 9, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Adds the plot method to the abstract spatial filters. Implements it for cone search.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.38%. Comparing base (3b55aa9) to head (40472be).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/core/search/abstract_search.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   97.66%   97.38%   -0.28%     
==========================================
  Files          39       43       +4     
  Lines        1540     1720     +180     
==========================================
+ Hits         1504     1675     +171     
- Misses         36       45       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2024

Before [38a77f9] After [1dbd2be] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_polygon_search
2.13±0.02s 2.16±0.02s 1.01 benchmarks.time_create_midsize_catalog
14.5±0.05s 14.3±0.01s 0.99 benchmarks.time_create_large_catalog
94.5±2ms 91.8±2ms 0.97 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

@smcguire-cmu smcguire-cmu merged commit a65912e into main Dec 9, 2024
10 of 12 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/search-plotting branch December 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants