Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper for catalog merge #48

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Wrapper for catalog merge #48

merged 4 commits into from
Nov 15, 2023

Conversation

camposandro
Copy link
Collaborator

@camposandro camposandro commented Nov 1, 2023

Implements an utility method that wraps Dask's Dataframe merge for a catalog.

@camposandro camposandro self-assigned this Nov 1, 2023
@camposandro camposandro changed the title Wrapper for Dataframe merge Wrapper for catalog merge Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49a169b) 98.94% compared to head (f4b8415) 98.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   98.94%   98.95%   +0.01%     
==========================================
  Files          21       21              
  Lines         473      479       +6     
==========================================
+ Hits          468      474       +6     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2023

Before [49a169b] After [45d34aa] Ratio Benchmark (Parameter)
34.0±0.4ms 33.4±0.3ms 0.98 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

Copy link

github-actions bot commented Nov 2, 2023

Before After Ratio Method
[d9e03f7] [b89a627]
31.3±0.2ms 30.9±0.2ms 0.99 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

@camposandro camposandro marked this pull request as ready for review November 2, 2023 15:58
@camposandro camposandro merged commit d523eb1 into main Nov 15, 2023
14 checks passed
@camposandro camposandro deleted the sandro/merge-catalogs branch January 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants