Merge pull request #47 from astronomy-commons/rm-kdtree-gnomonic

Remove previous implementation of kdtree x-match

benchmarks/benchmarks.py

@@ -5,7 +5,6 @@
 import os
 
 import lsdb
-from lsdb.core.crossmatch.kdtree_gnomonic_match import KdTreeGnomonicCrossmatch
 
 TEST_DIR = os.path.join(os.path.dirname(__file__), "..", "tests")
 DATA_DIR_NAME = "data"
@@ -28,10 +27,3 @@ def time_kdtree_crossmatch():
     small_sky = load_small_sky()
     small_sky_xmatch = load_small_sky_xmatch()
     small_sky.crossmatch(small_sky_xmatch).compute()
-
-
-def time_kdtree_gnomonic_crossmatch():
-    """Time computations are prefixed with 'time'."""
-    small_sky = load_small_sky()
-    small_sky_xmatch = load_small_sky_xmatch()
-    small_sky.crossmatch(small_sky_xmatch, algorithm=KdTreeGnomonicCrossmatch).compute()

pyproject.toml

@@ -20,7 +20,6 @@ dependencies = [
     "pyarrow",
     "deprecated",
     "ipykernel", # Support for Jupyter notebooks
-    "scikit-learn",
     "scipy", # kdtree
 ]
 

tests/lsdb/catalog/test_crossmatch.py

@@ -3,11 +3,10 @@
 from hipscat.pixel_math.hipscat_id import HIPSCAT_ID_COLUMN
 
 from lsdb.core.crossmatch.abstract_crossmatch_algorithm import AbstractCrossmatchAlgorithm
-from lsdb.core.crossmatch.kdtree_gnomonic_match import KdTreeGnomonicCrossmatch
 from lsdb.core.crossmatch.kdtree_match import KdTreeCrossmatch
 
 
-@pytest.mark.parametrize("algo", [KdTreeCrossmatch, KdTreeGnomonicCrossmatch])
+@pytest.mark.parametrize("algo", [KdTreeCrossmatch])
 class TestCrossmatch:
     @staticmethod
     def test_kdtree_crossmatch(algo, small_sky_catalog, small_sky_xmatch_catalog, xmatch_correct):