Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid celery example usage #170

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

abhishekbhakat
Copy link
Contributor

Description

HYBRID example usage for CELERY is missing and it needs node_pool_id.

🎟 Issue(s)

NA

🧪 Functional Testing

NA

📸 Screenshots

NA

📋 Checklist

  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Updated any related documentation

Didn't updated the docs. I guess they are supposed to be autogenerated using tfplugindocs generate ??

@abhishekbhakat abhishekbhakat requested review from vandyliu and a team as code owners November 13, 2024 11:53
@vandyliu
Copy link
Collaborator

vandyliu commented Dec 3, 2024

Hey! Thanks for the PR. It looks good but docs weren't generated yet. It can automatically be generated by running make build in the root directory of the repository.

Copy link
Collaborator

@ichung08 ichung08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@vandyliu vandyliu merged commit d1333d4 into astronomer:main Dec 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants