-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading default_args from shared defaults.yml #330
Conversation
b0ac267
to
b0a35c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 93.57% 93.65% +0.08%
==========================================
Files 10 10
Lines 778 788 +10
==========================================
+ Hits 728 738 +10
Misses 50 50 ☔ View full report in Codecov by Sentry. |
38cb926
to
4049822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot, @pankajastro!
ca13b11
to
9c7ac52
Compare
closes: #297
Currently, DAG Factory provides two places to configure default_args:
The second option overrides the first one.
Post this PR, the user can also keep the default_args in the
defaults.yml
file. The configuration fromdefaults.yml
will be applied to all DAG Factory DAGSample
defaults.yml
The precedence for default_args will be as follows, after this implementation:
i.e At DAG configuration YML will take precedence.