Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Markdown pre-commit checks #329

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Add Markdown pre-commit checks #329

merged 6 commits into from
Jan 3, 2025

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Jan 2, 2025

  • Linting
  • Codespell (spelling)
  • Dead link check

And fixes problems identified by them when running:

pre-commit run --all-files

@tatiana tatiana requested a review from a team January 2, 2025 12:22
@tatiana tatiana force-pushed the add-mk-precommit-checks branch from 70d8903 to 316fb79 Compare January 2, 2025 12:23
@tatiana tatiana added this to the DAG Factory 0.22.0 milestone Jan 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (e9f9929) to head (d403a02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files          10       10           
  Lines         778      778           
=======================================
  Hits          726      726           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana marked this pull request as ready for review January 2, 2025 15:56
@tatiana tatiana requested a review from a team as a code owner January 2, 2025 15:56
mkdocs.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these checks. Also, would like to seek attention on whether we need to restore the mkdocs.yml file that's currently getting removed with this PR.

@tatiana tatiana force-pushed the add-mk-precommit-checks branch from 639c547 to d403a02 Compare January 3, 2025 11:17
@tatiana tatiana merged commit 2a4caa7 into main Jan 3, 2025
67 checks passed
@tatiana tatiana deleted the add-mk-precommit-checks branch January 3, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants