Fix issue with API response not containing all tags for runtime version update #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
for more information, see https://pre-commit.ci
Lee-W
approved these changes
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 94 94
Lines 4636 4636
=======================================
Hits 4559 4559
Misses 77 77 ☔ View full report in Codecov by Sentry. |
pankajkoti
reviewed
Apr 19, 2024
Comment on lines
31
to
32
|
|
||
| # print(latest_tag) |
There was a problem hiding this comment.
Suggested change
| # print(latest_tag) |
pankajkoti
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the action job to update the runtime version in the integration test deployment created a PR in which the version was not the latest. After debugging, we found out that the response from the API call does not contain all the tags. This PR addresses the issue after adding a limit query parameter