Correct google cloud-sdk download URL protocol to https from http #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we have been observing failures to build our integration tests docker images precisely at the step where we download the google cloud-sdk library. It has been observed that the previously working http URL is no longer available and we need to use a https URL. This PR corrects the same for successful build of the image. closes: #1488
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 94 94
Lines 4635 4635
=======================================
Hits 4558 4558
Misses 77 77 ☔ View full report in Codecov by Sentry. |
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
pankajastro
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we have been observing failures to build our
integration tests docker images precisely at the step
where we download the google cloud-sdk library. It has
been observed that the previously working http URL is
no longer available and we need to use a https URL.
This PR corrects the same for successful build of the image.
closes: #1488