Nuke EKS clusters #1407
Merged
Nuke EKS clusters #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
phanikumv
approved these changes
Dec 29, 2023
pankajkoti
reviewed
Dec 29, 2023
| @@ -125,6 +131,15 @@ def check_dag_status(**kwargs: Any) -> None: | |||
| f"aws emr-containers list-virtual-clusters --state RUNNING --region {AWS_DEFAULT_REGION} | jq -r '.virtualClusters[].id' | xargs -I % aws emr-containers delete-virtual-cluster --id % --region {AWS_DEFAULT_REGION}; ", | |||
| ) | |||
|
|
|||
| terminate_regression_clusters = BashOperator( | |||
| task_id="terminate_regression_clusters", | |||
There was a problem hiding this comment.
let's mention here that these are from Astro SDK
e.g. terminate_astro_sdk_regression_clusters or terminate_dag_authoring_regression_clusters
There was a problem hiding this comment.
terminate_dag_authoring_regression_clusters would be better
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 91 91
Lines 5364 5364
=======================================
Hits 5286 5286
Misses 78 78 ☔ View full report in Codecov by Sentry. |
pankajastro
reviewed
Dec 29, 2023
| f"aws configure set aws_access_key_id {REGRESSION_CLUSTER_AWS_ACCESS_KEY}; " | ||
| f"aws configure set aws_secret_access_key {REGRESSION_CLUSTER_AWS_SECRET_ACCESS_KEY}; " | ||
| f"aws configure set default.region {REGRESSION_CLUSTER_AWS_DEFAULT_REGION}; " | ||
| f"sh $AIRFLOW_HOME/dags/delete_eks_cluster_and_nodes.sh {REGRESSION_CLUSTER_AWS_DEFAULT_REGION}", |
There was a problem hiding this comment.
do we need to pass REGRESSION_CLUSTER_AWS_DEFAULT_REGION as a parameter can't we access it in the bash file directly with something like ${REGRESSION_CLUSTER_AWS_DEFAULT_REGION}?
pankajastro
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the deletion of an EKS cluster from the nuke DAG.