Fixes to move deployment to stage env #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 91 91
Lines 5458 5458
=======================================
Hits 5380 5380
Misses 78 78 ☔ View full report in Codecov by Sentry. |
|
Tested my Changes working fine - https://github.com/astronomer/astronomer-providers/actions/runs/6970676392/job/18969102769 |
pankajkoti
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving the deployments to the stage, we had to make some fixes in the script. sh and GitHub Actions files.