Fix azure provider breaking change #1341
Conversation
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200 and
utkarsharma2
as code owners
| ) | ||
| adf_client.linked_services.create_or_update( | ||
| RESOURCE_GROUP_NAME, DATAFACTORY_NAME, STORAGE_LINKED_SERVICE_NAME, ls_azure_storage | ||
| ) | ||
|
|
||
| # Create an Azure blob dataset (input) | ||
| ds_ls = LinkedServiceReference(reference_name=STORAGE_LINKED_SERVICE_NAME) | ||
| ds_ls = LinkedServiceReference(type="LinkedServiceReference", reference_name=STORAGE_LINKED_SERVICE_NAME) |
There was a problem hiding this comment.
Do we need to support/take care of backward compatibility for the previous versions of the provider?
There was a problem hiding this comment.
There was a problem hiding this comment.
And we used to install azure-mgmt-datafactory >= 1.0.0 here.
There was a problem hiding this comment.
Also as an example DAG, I think we should use the newer version. WDYT?
| ds_in_ref = DatasetReference(type="DatasetReference", reference_name=DATASET_INPUT_NAME) | ||
| ds_out_ref = DatasetReference(type="DatasetReference", reference_name=DATASET_OUTPUT_NAME) |
There was a problem hiding this comment.
same question for backward compatibility.
|
Looks like there is a mypy failure, also could we add a screenshot of a successful DAG run (either local or on Astro Cloud)? |
I think it's because it was not released by then. Yep, let me deploy one more time. The DAG disappeared (as expected) . cannot screenshot the last successful DAG run |
Lee-W
force-pushed
the
fix-azure-provider-breaking-change
branch
from
085fafc to
0165bff
Compare
this is added in newer version of datafactory lib
Lee-W
force-pushed
the
fix-azure-provider-breaking-change
branch
from
b097a7e to
0c09b44
Compare
Lee-W
force-pushed
the
fix-azure-provider-breaking-change
branch
from
0684657 to
bdef5a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
+ Coverage 98.55% 98.56% +0.01%
==========================================
Files 91 91
Lines 5456 5454 -2
==========================================
- Hits 5377 5376 -1
+ Misses 79 78 -1
☔ View full report in Codecov by Sentry. |
This PR fixes the failure due to https://pypi.org/project/apache-airflow-providers-microsoft-azure/8.0.0rc1/