Skip to content

Commit

Permalink
Add non-ASCII logs check task in master dag (#1427)
Browse files Browse the repository at this point in the history
This PR is to test the astronomer logging provider for non-ASCII character, as we have providers tests running on all cloud providers daily, This will help us test daily without creating additional deployments.
  • Loading branch information
vatsrahul1001 authored Jan 12, 2024
1 parent a49fe81 commit 86015d3
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions .circleci/integration-tests/master_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def prepare_dag_dependency(task_info, execution_time):
)

get_airflow_version = BashOperator(
task_id="get_airflow_version", bash_command="airflow version", do_xcom_push=True
task_id="get_airflow_version", bash_command="airflow version && echo åäö", do_xcom_push=True
)
check_logs_data = PythonOperator(
task_id="check_logs",
Expand All @@ -199,7 +199,20 @@ def prepare_dag_dependency(task_info, execution_time):
],
)

airflow_version_check = (get_airflow_version, check_logs_data)
# The below task `check_non_ascii_data` is specifically added to test the astronomer logging
# providers for non-ASCII characters, as we have providers' tests running on all
# cloud providers, and we do not want multiple deployments for this.
check_non_ascii_data = PythonOperator(
task_id="check_non_ascii_data",
python_callable=check_log,
op_args=[
"get_airflow_version",
"åäö",
"this_string_should_not_be_present_in_logs",
],
)

airflow_version_check = (get_airflow_version, check_logs_data, check_non_ascii_data)
chain(*airflow_version_check)

get_airflow_executor = BashOperator(
Expand Down

0 comments on commit 86015d3

Please sign in to comment.