Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document contributor roles and add maintainers list #734

Merged
merged 11 commits into from
Dec 4, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 1, 2023

Add documentation about Astronomer Cosmos contributor roles and maintainers until now.

@tatiana tatiana requested a review from a team as a code owner December 1, 2023 16:02
@tatiana tatiana requested a review from a team December 1, 2023 16:02
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 1, 2023
Copy link

netlify bot commented Dec 1, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 897d34b
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/656df340245ef60008305b6a

@dosubot dosubot bot added area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality labels Dec 1, 2023
@tatiana tatiana changed the title Add contributor roles and names Document contributor roles and add maintainers list Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abeb15c) 92.99% compared to head (82db500) 92.99%.
Report is 1 commits behind head on main.

❗ Current head 82db500 differs from pull request most recent head 897d34b. Consider uploading reports for the commit 897d34b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          55       55           
  Lines        2313     2313           
=======================================
  Hits         2151     2151           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors.rst Outdated Show resolved Hide resolved
Replace inactive by emeritus.
Change releases to be an Astronomer responsibility.
Restore Chris as an active maintainer.
Associate general contributions to general contributors (not only maintainers)
docs/contributors-roles.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@harels harels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition to project governance

docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors-roles.rst Outdated Show resolved Hide resolved
docs/contributors.rst Outdated Show resolved Hide resolved
Address @jlaneve feedback

Co-authored-by: Julian LaNeve <[email protected]>
docs/contributors.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one more small comment (missed it during the first pass) but otherwise looks great, thank you for adding this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2023
Co-authored-by: Julian LaNeve <[email protected]>
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Dec 4, 2023
@tatiana tatiana merged commit e1f34ea into main Dec 4, 2023
39 checks passed
@tatiana tatiana deleted the commiter-guidelines branch December 4, 2023 15:43
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Add documentation about Astronomer Cosmos contributor roles and
maintainers until now.

---------
Co-authored-by: Harel Shein <[email protected]>
Co-authored-by: Julian LaNeve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants