Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no profile_config for K8s & Docker #721

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Support no profile_config for K8s & Docker #721

merged 2 commits into from
Dec 5, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Nov 28, 2023

Make profile_config optional for users using ExecutionMode.KUBERTES and DOCKER.

Solve the issue raised by @david-mag in the #airflow-dbt slack channel:
https://apache-airflow.slack.com/archives/C059CC42E9W/p1700814078752829

@tatiana tatiana requested a review from a team as a code owner November 28, 2023 14:22
@tatiana tatiana requested a review from a team November 28, 2023 14:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit ab21106
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/656e53545675e7000831527c

@dosubot dosubot bot added area:config Related to configuration, like YAML files, environment variables, or executer configuration execution:docker Related to Docker execution environment labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1f34ea) 92.99% compared to head (ab21106) 93.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   92.99%   93.01%   +0.01%     
==========================================
  Files          55       55              
  Lines        2313     2319       +6     
==========================================
+ Hits         2151     2157       +6     
  Misses        162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana added this to the 1.3.0 milestone Nov 30, 2023
Copy link
Contributor

@harels harels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tatiana tatiana merged commit 32ccc6b into main Dec 5, 2023
42 checks passed
@tatiana tatiana deleted the no-profile branch December 5, 2023 11:18
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Make `profile_config` optional for users using ExecutionMode.KUBERTES
and DOCKER.

Solve the issue raised by @david-mag in the #airflow-dbt slack channel:
https://apache-airflow.slack.com/archives/C059CC42E9W/p1700814078752829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config Related to configuration, like YAML files, environment variables, or executer configuration execution:docker Related to Docker execution environment size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants