-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add config to TaskInstance
context
#700
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
e672125
to
d47889a
Compare
d47889a
to
be5c79c
Compare
Getting type check failures because of pre python 3.9 available type hint syntax that is being used, like |
Thanks for working on this!
@wseaton it's possible to avoid this exception in previous versions of Python by using I'm changing this PR to draft mode - please, move it back to a non-draft PR once the branch is rebased and the tests are passing. |
hi @wseaton are you still working on this PR or could we close this? |
@wseaton, we find this very useful; please, if you have a chance, we'd love to see this work resumed! For now, we're starting to close stale PRs - but please let us know if we can help you get this work to the finishing line. Feel free to reopen or create a new PR. |
Thanks @tatiana, to be honest I actually forget why I needed this. Do you have any examples you can share publicly of how this would be useful? Perhaps I can pick it back up. Edit: My linked issue shows why: #698 (comment), there is DBT specific DAG metadata that would be useful to have available to route via webhooks. |
Sorry for hijacking this, I have a use case for this feature and would like to contribute. I have created a draft PR to implement this feature :) |
Description
forwards context from the parsed model config object to the Airflow
TaskInstance
Context
so it is available in callback functionsRelated Issue(s)
closes #698
Breaking Change?
not that I'm aware
Checklist
Would like guidance on where you'd like the tests for this, eg. mocked in the operators section or integration.