Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight DAG examples in README #695

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

iancmoritz
Copy link
Contributor

Description

After speaking with customers, it looks like it would be more clear to flag our examples in the dev folder in the README.

Related Issue(s)

Breaking Change?

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@iancmoritz iancmoritz requested a review from a team as a code owner November 20, 2023 15:21
@iancmoritz iancmoritz requested a review from a team November 20, 2023 15:21
Copy link

netlify bot commented Nov 20, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit ec95fe5
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/655dd6e75eb73600087e2c01

@dosubot dosubot bot added the area:docs Relating to documentation, changes, fixes, improvement label Nov 20, 2023
README.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b538a5) 92.93% compared to head (c1e31df) 92.88%.
Report is 1 commits behind head on main.

❗ Current head c1e31df differs from pull request most recent head ec95fe5. Consider uploading reports for the commit ec95fe5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   92.93%   92.88%   -0.05%     
==========================================
  Files          55       55              
  Lines        2292     2248      -44     
==========================================
- Hits         2130     2088      -42     
+ Misses        162      160       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Julian LaNeve <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 22, 2023
@tatiana tatiana added this to the 1.2.5 milestone Nov 22, 2023
@tatiana tatiana changed the title Flag examples in README Highlight DAG examples in README Nov 22, 2023
@tatiana tatiana merged commit 24aa38e into main Nov 22, 2023
39 checks passed
@tatiana tatiana deleted the feature/add-examples-in-readme branch November 22, 2023 10:37
This was referenced Nov 23, 2023
pull bot pushed a commit to pgoslatara/astronomer-cosmos that referenced this pull request Nov 24, 2023
Bug fixes

* Fix running models that use alias while supporting dbt versions by
@binhnq94 in astronomer#662
* Make profiles_yml_path optional for ExecutionMode.DOCKER and
KUBERNETES by @MrBones757 in astronomer#681
* Prevent overriding dbt profile fields with profile args of type or
method by @jbandoro in astronomer#702
* Fix LoadMode.DBT_LS fail when dbt outputs WarnErrorOptions by
@adammarples in astronomer#692
* Add support for env vars in RenderConfig for dbt ls parsing by
@jbandoro in astronomer#690
* Add support for Kubernetes on_warning_callback by @david-mag in astronomer#673
* Fix ExecutionConfig.dbt_executable_path to use ``default_factory`` by
@jbandoro in astronomer#678

Others

* Docs fix: example DAG in the README and docs/index by @tatiana in astronomer#705
* Docs improvement: highlight DAG examples in README by @iancmoritz and
@jlaneve in astronomer#695

(cherry picked from commit 2878d6a)
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
After speaking with customers, it looks like it would be more clear to
flag our examples in the dev folder in the README.

Co-authored-by: Julian LaNeve <[email protected]>
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Bug fixes

* Fix running models that use alias while supporting dbt versions by
@binhnq94 in astronomer#662
* Make profiles_yml_path optional for ExecutionMode.DOCKER and
KUBERNETES by @MrBones757 in astronomer#681
* Prevent overriding dbt profile fields with profile args of type or
method by @jbandoro in astronomer#702
* Fix LoadMode.DBT_LS fail when dbt outputs WarnErrorOptions by
@adammarples in astronomer#692
* Add support for env vars in RenderConfig for dbt ls parsing by
@jbandoro in astronomer#690
* Add support for Kubernetes on_warning_callback by @david-mag in astronomer#673
* Fix ExecutionConfig.dbt_executable_path to use ``default_factory`` by
@jbandoro in astronomer#678

Others

* Docs fix: example DAG in the README and docs/index by @tatiana in astronomer#705
* Docs improvement: highlight DAG examples in README by @iancmoritz and
@jlaneve in astronomer#695

(cherry picked from commit 2878d6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants