Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return code or error ignores WarnErrorOptions #692

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Return code or error ignores WarnErrorOptions #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2358fdb
ignore WarnErrorOptions string
adammarples Nov 20, 2023
c94ef67
add a test for WarnErrorOptions string passing if found in stdout
adammarples Nov 20, 2023
45e7635
Merge branch 'main' into return-code-or-error
tatiana Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cosmos/dbt/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def run_command(command: list[str], tmp_dir: Path, env_vars: dict[str, str]) ->
"Unable to run dbt ls command due to missing dbt_packages. Set RenderConfig.dbt_deps=True."
)

if returncode or "Error" in stdout:
if returncode or "Error" in stdout.replace("WarnErrorOptions", ""):
details = stderr or stdout
raise CosmosLoadDbtException(f"Unable to run {command} due to the error:\n{details}")

Expand Down
1 change: 1 addition & 0 deletions tests/dbt/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ def test_load_dbt_ls_and_manifest_with_model_version(load_method):
"stdout,returncode",
[
("all good", None),
("WarnErrorOptions", None),
pytest.param("fail", 599, marks=pytest.mark.xfail(raises=CosmosLoadDbtException)),
pytest.param("Error", None, marks=pytest.mark.xfail(raises=CosmosLoadDbtException)),
],
Expand Down
Loading