Fix installing deps when using profile_mapping & ExecutionMode.LOCAL

[joppevos]

Description

Extends the local operator when running dbt deps with the provides profile flags.
This makes the logic consistent between DAG parsing and task running as referenced below

astronomer-cosmos/cosmos/dbt/graph.py

Lines 247 to 266 in 8e2d590

	self.local_flags = [
	"--project-dir",
	str(tmpdir),
	"--profiles-dir",
	str(profile_path.parent),
	"--profile",
	self.profile_config.profile_name,
	"--target",
	self.profile_config.target_name,
	]
	self.log_dir = Path(env.get(DBT_LOG_PATH_ENVVAR) or tmpdir_path / DBT_LOG_DIR_NAME)
	self.target_dir = Path(env.get(DBT_TARGET_PATH_ENVVAR) or tmpdir_path / DBT_TARGET_DIR_NAME)
	env[DBT_LOG_PATH_ENVVAR] = str(self.log_dir)
	env[DBT_TARGET_PATH_ENVVAR] = str(self.target_dir)
	if self.render_config.dbt_deps:
	deps_command = [self.dbt_cmd, "deps"]
	deps_command.extend(self.local_flags)
	stdout = run_command(deps_command, tmpdir_path, env)
	logger.debug("dbt deps output: %s", stdout)

Related Issue(s)

closes #658

Breaking Change?

Checklist

• I have made corresponding changes to the documentation (if required)
• I have added tests that prove my fix is effective or that my feature works

[netlify]

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name	Link
🔨 Latest commit	58292c7
🔍 Latest deploy log	https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/654d08368a19f200086a9a48

[tatiana]

This was super quick, @joppevos , thank you for fixing this issue.

The only thing missing is a test. I believe we could add a unit test in astronomer-cosmos/tests/operators/test_local.py, calling run_command and mocking run_subprocess, and checking if we're passing the expected arguments.

There is something similar in:

astronomer-cosmos/tests/operators/test_local.py

Lines 369 to 373 in 188fe56

	@patch("cosmos.operators.local.DbtLocalBaseOperator.build_and_run_cmd")
	def test_operator_execute_with_flags(mock_build_and_run_cmd, operator_class, kwargs, expected_call_kwargs):
	task = operator_class(profile_config=profile_config, task_id="my-task", project_dir="my/dir", **kwargs)
	task.execute(context={})
	mock_build_and_run_cmd.assert_called_once_with(**expected_call_kwargs)

The motivation to have a test is to make sure we don't re-introduce this bug in the future.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9001c98) 92.71% compared to head (58292c7) 92.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   92.71%   92.72%   +0.01%     
==========================================
  Files          54       54              
  Lines        2223     2227       +4     
==========================================
+ Hits         2061     2065       +4     
  Misses        162      162              

Files	Coverage Δ
cosmos/operators/local.py	91.74% <100.00%> (+0.09%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tatiana]

Thanks for working on this and addressing the feedback so quickly, @joppevos !
We'll merge it once the checks pass.

[joppevos]

Thanks for working on this and addressing the feedback so quickly, @joppevos ! We'll merge it once the checks pass.

Sounds good! Thanks for the support @tatiana :)

[tatiana]

Thanks for the contribution, @joppevos , we released it as part of Cosmos 1.2.4 yesterday:
https://github.com/astronomer/astronomer-cosmos/releases/tag/astronomer-cosmos-v1.2.4