Support ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
|
Docs changes still need to be completed, though all the core logic and baseline tests in its current state has been implemented. @tatiana could you please have a scan over the changes in this MR and let me know if there are any other changes you'd like to see before i finalize the docs / tests? |
tatiana
reviewed
Oct 30, 2023
There was a problem hiding this comment.
@MrBones757, this looks great, thank you!
I left two minor comments - I'll review them again after the checks are passed.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 93.41% 92.66% -0.76%
==========================================
Files 53 53
Lines 2158 2168 +10
==========================================
- Hits 2016 2009 -7
- Misses 142 159 +17
☔ View full report in Codecov by Sentry. |
|
I've added some additional tests to captures some more edge cases i found and add additional coverage. All unit tests are running fine locally, and all integration tests other than databricks are too (no token for this) |
|
Since the initial integration tests look good, is there anything else that needs to be done here :) |
2 tasks
…er for new Fields. Simplified Graph interaction to consume RenderConfig natively. Updates tests to reflect changes
…onfig.dbt_project_path or ProjectConfig.manifest_path as we now support defining dbt_project_path in ExecutionConfig and RenderConfig
…t_path to dbtGraph
tatiana
changed the title
ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution
tatiana
pushed a commit
that referenced
this pull request
Nov 6, 2023
… Rendering and Execution (#634) This MR finishes the work that was started in #605 to add full support for ProjectConfig.dbt_project_path = None, and implements #568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: #568 (cherry picked from commit b64eb9a)
tatiana
added a commit
that referenced
this pull request
Nov 6, 2023
Bug fixes * Support ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution by @MrBones757 in #634 * Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM by @edgga in #615 Others * Add pre-commit hook for McCabe max complexity check and fix errors by @jbandoro in #629 * Update contributing docs for running integration tests by @jbandoro in #638 * Fix CI issue running integration tests by @tatiana in #640 and #644 * pre-commit updates in #637
Merged
tatiana
pushed a commit
that referenced
this pull request
Nov 6, 2023
… Rendering and Execution (#634) This MR finishes the work that was started in #605 to add full support for ProjectConfig.dbt_project_path = None, and implements #568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: #568 (cherry picked from commit b64eb9a)
tatiana
added a commit
that referenced
this pull request
Nov 6, 2023
Bug fixes * Support ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution by @MrBones757 in #634 * Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM by @edgga in #615 Others * Add pre-commit hook for McCabe max complexity check and fix errors by @jbandoro in #629 * Update contributing docs for running integration tests by @jbandoro in #638 * Fix CI issue running integration tests by @tatiana in #640 and #644 * pre-commit updates in #637
tatiana
added a commit
that referenced
this pull request
Nov 7, 2023
Bug fixes * Support ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution by @MrBones757 in #634 * Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM by @edgga in #615 Others * Add pre-commit hook for McCabe max complexity check and fix errors by @jbandoro in #629 * Update contributing docs for running integration tests by @jbandoro in #638 * Fix CI issue running integration tests by @tatiana in #640 and #644 * pre-commit updates in #637 (cherry picked from commit fa0620a)
LennartKloppenburg
pushed a commit
to LennartKloppenburg/astronomer-cosmos
that referenced
this pull request
Nov 17, 2023
… Rendering and Execution (astronomer#634) This MR finishes the work that was started in astronomer#605 to add full support for ProjectConfig.dbt_project_path = None, and implements astronomer#568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: astronomer#568
LennartKloppenburg
pushed a commit
to LennartKloppenburg/astronomer-cosmos
that referenced
this pull request
Dec 17, 2023
… Rendering and Execution (astronomer#634) This MR finishes the work that was started in astronomer#605 to add full support for ProjectConfig.dbt_project_path = None, and implements astronomer#568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: astronomer#568
tatiana
pushed a commit
that referenced
this pull request
Jul 4, 2024
… Rendering and Execution (#634) This MR finishes the work that was started in #605 to add full support for ProjectConfig.dbt_project_path = None, and implements #568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: #568
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Bug fixes * Support ProjectConfig.dbt_project_path = None & different paths for Rendering and Execution by @MrBones757 in astronomer#634 * Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM by @edgga in astronomer#615 Others * Add pre-commit hook for McCabe max complexity check and fix errors by @jbandoro in astronomer#629 * Update contributing docs for running integration tests by @jbandoro in astronomer#638 * Fix CI issue running integration tests by @tatiana in astronomer#640 and astronomer#644 * pre-commit updates in astronomer#637 (cherry picked from commit fa0620a)
tatiana
pushed a commit
that referenced
this pull request
Jul 29, 2024
… Rendering and Execution (#634) This MR finishes the work that was started in #605 to add full support for ProjectConfig.dbt_project_path = None, and implements #568. Within this PR, several things have been updated: 1 - Added project_path fields to RenderConfig and ExecutionConfig 2 - Simplified the consumption of RenderConfig in the dbtGraph class 3 - added option to configure different dbt executables for Rendering vs Execution. Closes: #568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR finishes the work that was started in #605 to add full support for ProjectConfig.dbt_project_path = None, and implements #568.
Within this PR, several things have been updated:
1 - Added project_path fields to RenderConfig and ExecutionConfig
2 - Simplified the consumption of RenderConfig in the dbtGraph class
3 - added option to configure different dbt executable for Rendering vs Execution.
Related Issue(s)
Closes: #568
Breaking Change?
None
Checklist