Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook for McCabe max complexity check and fix errors #629

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Add pre-commit hook for McCabe max complexity check and fix errors #629

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
37155a9
add pre-commit hook for mccabe max complexity check
jbandoro Oct 26, 2023
a4c9341
fix: LegacyDbtProject._handle_config_file complexity
jbandoro Oct 26, 2023
f030c47
use in-place operator
jbandoro Oct 26, 2023
47f7033
fix: DbtGraph.load_via_dbt_ls complexity
jbandoro Oct 27, 2023
8cb7b78
add test coverage for new functions
jbandoro Oct 27, 2023
9546589
Revert "use in-place operator"
jbandoro Oct 27, 2023
20e00ea
fix complexity of DbtModel.__post_init__
jbandoro Oct 30, 2023
a98eeda
Merge branch 'main' into 525-add-pre-commit-hook-max-complexity
jbandoro Oct 30, 2023
9d853e2
rm read_text()
jbandoro Oct 30, 2023
ceb1dac
fix complexity of select_nodes_ids_by_intersection
jbandoro Oct 31, 2023
52dabad
Merge branch 'main' into 525-add-pre-commit-hook-max-complexity
jbandoro Oct 31, 2023
f364382
fix integration test error catching
jbandoro Oct 31, 2023
0295fce
fix integration tests other errors raised
jbandoro Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ repos:
name: mypy-python
additional_dependencies: [types-PyYAML, types-attrs, attrs, types-requests, types-python-dateutil, apache-airflow]
files: ^cosmos
- repo: https://github.com/pycqa/flake8
rev: 6.1.0
hooks:
- id: flake8
entry: pflake8
additional_dependencies: [pyproject-flake8]

ci:
autofix_commit_msg: 🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,3 +250,7 @@ line-length = 120

[tool.distutils.bdist_wheel]
universal = true

[tool.flake8]
max-complexity = 10
select = "C"
Loading