Honour OPENLINEAGE_DISABLED env var
#622
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
ivanstillfront
temporarily deployed
to
external
GitHub Actions
Inactive
| @@ -227,7 +231,7 @@ def run_command( | |||
| output_encoding=self.output_encoding, | |||
| cwd=tmp_project_dir, | |||
| ) | |||
| if is_openlineage_available: | |||
| if is_openlineage_enabled: | |||
There was a problem hiding this comment.
@ivanstillfront Thanks for looking into this!
I'm not convinced about this change since this line aims to set Airflow inlets and outlets - unrelated to emitting open lineage events - but to support Airflow Data Aware scheduling.
This is being improved, but it will likely only be available in Cosmos 1.3 or 1.4.
Does the following comment address your original issue?
#612 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 93.32% 93.33%
=======================================
Files 54 54
Lines 2128 2129 +1
=======================================
+ Hits 1986 1987 +1
Misses 142 142
☔ View full report in Codecov by Sentry. |
|
@ivanstillfront The original issue you were facing in #612 should have been fixed as part of this release: |
Description
This allows dbt tasks to succeed successfully when lineage has been disabled by honouring the
OPENLINEAGE_DISABLEDenvironment variable that Airflow uses.Related Issue(s)
This does not resolve, but is related to #612. It allows us to run dbt tasks without having errors described in the issue.
Breaking Change?
This should not break anything.
Checklist