Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selector.py closes #506 #507

Closed
wants to merge 1 commit into from
Closed

Conversation

Tarjei400
Copy link

Description

Only log from not supported filter, utill you figure how you would like to validate incomming selectors.
This PR at least allows selectors that are not taken into account by a validator like in case of LS LoadMode

Related Issue(s)

Checklist

  • [-] I have made corresponding changes to the documentation (if required)
  • [-] I have added tests that prove my fix is effective or that my feature works - tested on my own airflow instance

Only log from not supported filter. This validator is not validating all of use cases
@Tarjei400 Tarjei400 requested a review from a team as a code owner September 4, 2023 09:36
@Tarjei400 Tarjei400 requested a review from a team September 4, 2023 09:36
@netlify
Copy link

netlify bot commented Sep 4, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 534ffb9
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64f5a51569560d00085a2b3b

Copy link

@odanu odanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Tarjei400 Tarjei400 closed this Sep 4, 2023
@tatiana
Copy link
Collaborator

tatiana commented Sep 5, 2023

Hey @Tarjei400, would you like to move forward with this change? Just noticed the PR was prematurely closed!

@Tarjei400
Copy link
Author

@tatiana I closed pr, as it turned out my change was utterly wrong, seems that cosmos has its own selector implementation if mode other than DBT_LS is used, hence that change would be wrong. The only hope of using selectors at the moment is by using DBT_LS mode, although scanning of dags gets severly extended due to this, but I was unable to find any other way.

@tatiana
Copy link
Collaborator

tatiana commented Oct 5, 2023

Thank you very much @Tarjei400. Even though it wasn't merged, we appreciate your contribution!

If you could share some examples of selectors you're trying to use and did not work with Cosmos selectors, we could have dedicated issues - so they can be worked on.

1 similar comment
@tatiana
Copy link
Collaborator

tatiana commented Oct 5, 2023

Thank you very much @Tarjei400. Even though it wasn't merged, we appreciate your contribution!

If you could share some examples of selectors you're trying to use and did not work with Cosmos selectors, we could have dedicated issues - so they can be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants