Enable Docs DAG in CI leveraging existing CI connections #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajkoti
force-pushed
the
enable-docs-dag
branch
from
c6c6a21 to
54b6d5f
Compare
Deploying astronomer-cosmos with
|
| Latest commit: |
d44d5bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bce3e21c.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://enable-docs-dag.astronomer-cosmos.pages.dev |
dosubot
bot
added
the
size:M
dosubot
bot
added
the
area:ci
|
Action run https://github.com/astronomer/astronomer-cosmos/actions/runs/12500718837/job/34877247783?pr=1428 before merging and rebasing PR #1422 here shows that we now are running the example DAG for docs upload test in our CI with this PR. |
pankajkoti
force-pushed
the
enable-docs-dag
branch
from
54b6d5f to
d44d5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the dbt docs DAG in our example DAGs suite was silently failing to run because the specified connections in the DAG were not present in our CI environment. I am removing the connection checks, allowing the previously skipped tasks to execute even when the remote Airflow connections are unavailable. Additionally, I’ve updated the DAG to use our existing CI credentials and Airflow connections, as well as updated the bucket name to the ones I created in our object stores. This change will help catch issues like #1420 earlier. While fix #1422 has already addressed #1420, this PR will now validate that the fix is functioning as expected.
closes: #1420