Address review comments on PR 1347 regarding profile_config for ExecutionMode.Docker #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Deploying astronomer-cosmos with
|
| Latest commit: |
df3bbc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96bf6df9.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://address-pr-1347-review-comme.astronomer-cosmos.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 71 71
Lines 4230 4233 +3
=======================================
+ Hits 4083 4086 +3
Misses 147 147 ☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks for addressing the feedback, @pankajkoti ! Happy for us to merge the community PR and then this one, considering the author of the original PR doesn't address the comments in the next few hours.
|
LGTM, thank you for doing this! |
andrewhlui
approved these changes
Dec 19, 2024
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the open review comments on PR #1347 which adds profile_config to Docker execution mode.
related: #1346
related: #1347