-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move default_args into kwargs #1382
base: main
Are you sure you want to change the base?
move default_args into kwargs #1382
Conversation
Small update to fix a bug where when using |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 67 67
Lines 4051 4053 +2
=======================================
+ Hits 3899 3901 +2
Misses 152 152 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @david-mag thanks for your contribution, please, could you add a test to cover this use-case?
added a test case for this |
…bernetes_operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @david-mag Just for my understanding could you please explain what is on_error_callback and share some DAG example how you are using it?
Oh, my mistake ... I mean |
Description
When using default argument for
on_error_callback
functions, it is not executed, because its in a sub-dictionary inkwargs
.