Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default_args into kwargs #1382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

david-mag
Copy link
Contributor

Description

When using default argument for on_error_callback functions, it is not executed, because its in a sub-dictionary in kwargs.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@dosubot dosubot bot added the area:config Related to configuration, like YAML files, environment variables, or executer configuration label Dec 11, 2024
@david-mag
Copy link
Contributor Author

Small update to fix a bug where when using on_failure_callback in the default_args, callbacks for dbt tests that fail won't be executed.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (110fb07) to head (238164c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          67       67           
  Lines        4051     4053    +2     
=======================================
+ Hits         3899     3901    +2     
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @david-mag thanks for your contribution, please, could you add a test to cover this use-case?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
@david-mag
Copy link
Contributor Author

added a test case for this

Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @david-mag Just for my understanding could you please explain what is on_error_callback and share some DAG example how you are using it?

@david-mag
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config Related to configuration, like YAML files, environment variables, or executer configuration size:S This PR changes 10-29 lines, ignoring generated files. stretch goal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants