-
Notifications
You must be signed in to change notification settings - Fork 177
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
kwargs
param in DocsOperator method upload_to_cloud_storage (#1422
) This PR addresses an issue where the `callback` callable parameter's handling was modified in PR #1389 leading to a change in the way keyword arguments like context were passed to the callable. However, the Docs Operator has its own implementation of the callback callable, which only expects a single parameter, project_dir. As a result, passing extra keyword arguments like context is causing a mismatch and resulting in the error described in #1420. This PR adds the `kwargs` param in `upload_to_cloud_storage` method of the Docs operators We have integration tests for these operator but look like CI does have not required setup and it get ignored. https://github.com/astronomer/astronomer-cosmos/blob/main/dev/dags/dbt_docs.py related: #1420
- Loading branch information
1 parent
dada5cf
commit 4ac32cf
Showing
3 changed files
with
12 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters