Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporated newly introduced test suite in pre-existing test cases for astro deploy command #1767

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Incorporated newly introduced test suite in pre-existing test cases for astro deploy command #1767

merged 4 commits into from
Jan 2, 2025

Conversation

rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Dec 17, 2024 •
edited
Loading

Description

Incorporated newly introduced test suite in pre-existing test cases for astro deploy command

🎟 Issue(s)

Related #6862

🧪 Functional Testing

Unit tests

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

neel-astro
neel-astro reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are other instances of houstonMock.AssertExpectations(s.T()) that could also be cleaned up in this file

neel-astro
neel-astro approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@neel-astro neel-astro merged commit b542de4 into 6859 Jan 2, 2025
3 of 4 checks passed
@neel-astro neel-astro deleted the 6862 branch January 2, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rujhan-arora-astronomer @neel-astro