Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct default_conn_name in class #95

Merged
merged 4 commits into from
May 27, 2024
Merged

Set correct default_conn_name in class #95

merged 4 commits into from
May 27, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented May 27, 2024 •
edited
Loading

The default_conn_name value is fivetran_default but class set it to fivetran

airflow-provider-fivetran-async/fivetran_provider_async/hooks.py

Line 42 in 59b5c20

default_conn_name = "fivetran_default"

@pankajastro pankajastro marked this pull request as ready for review May 27, 2024 13:06
phanikumv
phanikumv reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to cover this?

pankajkoti
pankajkoti approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. yes, test cases would be nice to have here as suggested by Phani.

@pankajastro pankajastro requested a review from phanikumv May 27, 2024 14:40
@phanikumv phanikumv merged commit fe5e4ea into main May 27, 2024
7 checks passed
@phanikumv phanikumv deleted the fix_default_connection_name branch May 27, 2024 15:02
@pankajastro pankajastro mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanikumv phanikumv phanikumv approved these changes

@pankajkoti pankajkoti pankajkoti approved these changes

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@sunank200 sunank200 Awaiting requested review from sunank200 sunank200 is a code owner

@utkarsharma2 utkarsharma2 Awaiting requested review from utkarsharma2 utkarsharma2 is a code owner

@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankajastro @pankajkoti @phanikumv