test number of total sources and split up by publication. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelle
requested changes
Aug 14, 2024
|
I think we should also check for the total number of sources. |
kelle
requested changes
Oct 22, 2024
| @@ -16,6 +16,9 @@ | |||
| from astrodbkit2.astrodb import or_ | |||
| import numpy as np | |||
|
|
|||
|
|
|||
| ###### now, we test database functionality, self-consistency, etc. ##### | |||
|
|
|||
| def test_setup_db(db): | |||
There was a problem hiding this comment.
In SIMPLE, I use a conftest.py to do these type of things.
| db.Sources.c.reference == reference, | ||
|
|
||
| ) | ||
| ).astropy() |
There was a problem hiding this comment.
You might be able to use .count() or similar instead of getting a table output
|
|
||
| from sqlalchemy import and_, or_ | ||
| import pytest | ||
| from astropy.io.votable.ucd import check_ucd, parse_ucd, UCDWords |
There was a problem hiding this comment.
None of these imports are used
|
Move test_coordinates test from test_database into test_sources.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #54.
So far, I've tested the number of sources in the database and the number of sources that correspond to each publication. Anything else we want to add?