-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to have references in separate sub-directory; closes #49 #77
Refactor to have references in separate sub-directory; closes #49 #77
Conversation
This looks great! One question, do we really want
Maybe we should we also have a
Another option is to make the
|
I do think they should be under I can explore that over the next week. For ease of comparison I'll probably create a new branch off of this one, but we ideally want to merge both together. So with that in place, we would have |
This is now ready to go. It stores references under Once this is merged, I'll make a major astrodbkit2 release and re-run the SIMPLE tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added some suggested wording to the documentation. I've seen lots of folks struggle with paths and directory structure so I tried to make the structure more explicit throughout.
Co-authored-by: Kelle Cruz <[email protected]>
This changes the database saving/loading logic to add an optional
reference_database
variable (defaults to "reference"). When set, any table set as reference will get stored in that sub-directory. This is backwards compatible in the sense that when loading a database, it will also check the parent directory if it doesn't file reference tables in the sub-directory.Closes #49