Hotfix/capabilites #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 1, 2016 14:35
Check to see if the error is possibly caused by closing the connection after unmounting.
This [commit](docker/go-plugins-helpers@7f7e1f8) extended the Volume Driver interface to require a capabilities method. It tells docker whether data is stored on the local host or in the container.
Occasionally on Centos vaultfs exits with a bad file descriptor error. I figure closing the connection before unmounting would help with this error.
This change cause `vault mount` to hang when attempting to kill the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package "github.com/docker/go-plugins-helpers/volume" extended the Driver Interface to have a "Capabilities" method that tells docker whether the volume keeps data on the host or in the container. I added the method so it doesn't break.