fix(shrinkwrap): remove shrinkwrap file #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shrinkwrap file is no longer needed... ?
|
Could you remove the reference to the shrinkwrap file from the Dockefile please? |
|
Ah yes. I did. I've also updated the node version in docker (to 20.15). |
nicojs
commented
Jul 8, 2024
| COPY libs libs/ | ||
| COPY plugins plugins/ | ||
| COPY decktape.js ./ | ||
|
|
||
| RUN npm install | ||
| RUN npm ci --omit=dev |
There was a problem hiding this comment.
By switching to ci --omit=dev we achieve 2 things:
- The docker pipeline fails when the lock-file is out of sync with the package.json file.
- We omit playwright and other
devDependenciesfrom installing
astefanutti
approved these changes
Jul 8, 2024
|
A friendly reminder to please create a release when you have the time @astefanutti 😘 |
|
@nicojs apologies for the delay. I've just released v3.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shrinkwrap file is no longer needed... ?
Closes #277
Closes #341