Code

Update nloptr c#169

Code

Open

aadler wants to merge 24 commits intoastamm:masterastamm/nloptr:masterfrom aadler:Update_nloptr_caadler/nloptr:Update_nloptr_cCopy head branch name to clipboard

+966-872

Commits

Commits on Jul 2, 2024

• Use Rinternals and not Rdefines and create shortcut definition for AS_INTEGER.

  aadler

  committed
  f625eef

• Can be included via the header file.

  aadler

  committed
  27eedbd

• Code formatting

  aadler

  committed
  499ea48

• Reduce the number of operations in the inner loop by calculating the "inner loop constant" before the loop.

  aadler

  committed
  867b916

• More code formatting

  aadler

  committed
  e4cedd3

• Spelling

  aadler

  committed
  5cd531f

• Instead of repeatedly calling the REAL macro inside a loop, it is more efficient to define a pointer outside the loop and use that instead.

  aadler

  committed
  b8168d2

• More "R-centric" to use these accessors for single-value reals or integers.

  aadler

  committed
  38b2f34

• More code formatting.

  aadler

  committed
  ace5a9e

• Convert the algorithm lookup from a nested if-else chain to a lookup table and switch statement. Should be more efficient (only 1 strcmp call) and more elegant.

  aadler

  committed
  c56c592

• Minor cleanup of test file for nloptr.c

  aadler

  committed
  dd38350

• This case cannot be tested since the nlopt_force_stop() function is not exposed to nloptr

  aadler

  committed
  0083ef1

• No longer relevant per WRE since all R is 64 bit.

  aadler

  committed
  b74463e

• NeedsCompilation is obvious. UseLTO is reasonable.

  aadler

  committed
  0416b66

• Update NEWS.md

  aadler

  committed
  5489061

• Update comments.

  aadler

  committed
  e3f74dd

• Where possible, declare and assign on the same line.

  aadler

  committed
  7ec4772

• Declare all counters inside their respective for loops and use size_t instead of int.

  aadler

  committed
  d3fa35e

• All should be > 0.

  aadler

  committed
  6307736

• Makes more sense to use unsigned size_t here. Adjust Rprintf accordingly.

  aadler

  committed
  b764e60

• Combine declaration and initialization for the rest of the SEXPs.

  aadler

  committed
  8e046be

• BUG FIX: Using "AS_INTEGER" coerces the value to int and nlopt_srand() needs a long. Instead, pass as a real and cast to long in C.

  aadler

  committed
  0a67e26

Commits on Jul 8, 2024

• Spelling/grammar

  aadler

  committed
  acc843c

• Update changelog

  aadler

  committed
  5a492f1