Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue that a warning was raised when there were no accepted bids #521

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

nick-harder
Copy link
Member

Fixes the issue that a warning was raised when there were no accepted… bids. This is normal behavior and should not raise a warning, as this can naturally happen. The warning is raised only of both accepted and rejected are empty

… bids. This is normal behavior and should not raise a warning, as this can naturally happen. The warning is raised only of both accepted and rejected are empty
@nick-harder nick-harder requested a review from maurerle December 11, 2024 14:20
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.52%. Comparing base (448425c) to head (70dfe08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
assume/markets/base_market.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   77.54%   77.52%   -0.02%     
==========================================
  Files          50       50              
  Lines        6790     6790              
==========================================
- Hits         5265     5264       -1     
- Misses       1525     1526       +1     
Flag Coverage Δ
pytest 77.52% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what we want to warn about, we should do this at the beginning of the clear_market function and just look at self.all_orders

@maurerle maurerle requested a review from kim-mskw December 11, 2024 14:37
@nick-harder nick-harder requested a review from maurerle December 11, 2024 15:16
@nick-harder nick-harder requested review from maurerle and kim-mskw and removed request for maurerle and kim-mskw December 13, 2024 10:12
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@nick-harder nick-harder merged commit 27f6365 into main Dec 16, 2024
7 of 9 checks passed
@nick-harder nick-harder deleted the fix-empty-market-results-warning branch December 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants