Fix delete db scenario #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the database engine is not created before this part
Mentioned in #512 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
+ Coverage 77.50% 77.54% +0.03%
==========================================
Files 50 50
Lines 6793 6790 -3
==========================================
Hits 5265 5265
+ Misses 1528 1525 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nick-harder
requested changes
Dec 10, 2024
examples/examples.py
Outdated
| @@ -107,7 +107,7 @@ | |||
| data_format = "local_db" # "local_db" or "timescale" | |||
|
|
|||
| # select the example to run from the available examples above | |||
| example = "small" | |||
| example = "small_learning_1" | |||
There was a problem hiding this comment.
the other two commits are used to reproduce the mentioned issue
Yes, I will revert those, once we know whats up with #512
assume/scenario/loader_csv.py
Outdated
| @@ -728,7 +728,7 @@ def load_scenario_folder( | |||
| study_case: str, | |||
| perform_evaluation: bool = False, | |||
| terminate_learning: bool = False, | |||
| episode: int = 1, | |||
| episode: int = 0, | |||
| eval_episode: int = 1, | |||
There was a problem hiding this comment.
should eval_episode be 0 as well?
There was a problem hiding this comment.
I didn't look into this change really, just applied it by recommendation in #512 but it did not help me reproduce an issue
-remove unrequired call for delete_similar_runs in run_learning function -move episode initilization back into init of output role -delete_similar_runs on start in output role when episode is 1 -clean up load_scenario_folder function as it doesn't require episode and other info any more -remove not setting up the world when episode==1 since this error no longer occurs -save last policies when exiting the loop to avoid confusion with numbering of last episode -adjust tutorial 04 as well
|
this also closes #517 |
nick-harder
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix the issue in
#512 (comment)
the first two commits are valid anyway, the other two commits are used to reproduce the mentioned issue (unsuccessfully on my side though)
The first two commits do:
on_readyEventually this helps