Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output lock #496

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Improve output lock #496

merged 1 commit into from
Nov 25, 2024

Conversation

maurerle
Copy link
Member

This reduces the duration in which the output role takes the lock on the dataframes.
Eventually this helps to maintain the same speedup for simulations as the output role runs in a separate process.

@maurerle maurerle requested a review from nick-harder November 25, 2024 10:58
@maurerle maurerle changed the base branch from main to pandas_wrapper November 25, 2024 11:00
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (b9cf60e) to head (a48f2f7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
assume/common/outputs.py 61.11% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files          50       50           
  Lines        6727     6727           
=======================================
  Hits         5154     5154           
  Misses       1573     1573           
Flag Coverage Δ
pytest 76.61% <61.11%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from pandas_wrapper to main November 25, 2024 15:44
@maurerle maurerle force-pushed the improve_output_lock branch from cd206be to a48f2f7 Compare November 25, 2024 15:52
@maurerle maurerle merged commit dde78c6 into main Nov 25, 2024
8 of 9 checks passed
@maurerle maurerle deleted the improve_output_lock branch November 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants