Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing database check when doing RL without a given database #492

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

maurerle
Copy link
Member

This fixes commands like:

assume -s example_02a -c tiny which did throw: AttributeError: 'NoneType' object has no attribute 'begin' before

This fixes commands like:
assume -s example_02a -c tiny
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (ef325c0) to head (fe85a55).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   76.47%   76.48%           
=======================================
  Files          49       49           
  Lines        6318     6319    +1     
=======================================
+ Hits         4832     4833    +1     
  Misses       1486     1486           
Flag Coverage Δ
pytest 76.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

though this does not bring noticable performance boosts
@kim-mskw
Copy link
Contributor

Interesting I'll review it @nick-harder

@kim-mskw kim-mskw merged commit b0aed76 into main Nov 21, 2024
9 checks passed
@kim-mskw kim-mskw deleted the fix_no_db_with_rl branch November 21, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants