Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new building DSM class #480

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

-remove duplicated code into a function

8b0bed3
Select commit
Loading
Failed to load commit list.
Open

Add the new building DSM class #480

-remove duplicated code into a function
8b0bed3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

77.05% (+0.33%) compared to 7602914

View this Pull Request on Codecov

77.05% (+0.33%) compared to 7602914

Details

Codecov Report

Attention: Patch coverage is 83.23353% with 28 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (7602914) to head (8b0bed3).

Files with missing lines Patch % Lines
assume/units/building.py 88.11% 17 Missing ⚠️
assume/units/dsm_load_shift.py 16.66% 10 Missing ⚠️
assume/common/utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   76.71%   77.05%   +0.33%     
==========================================
  Files          50       51       +1     
  Lines        6412     6558     +146     
==========================================
+ Hits         4919     5053     +134     
- Misses       1493     1505      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.