Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed buffer add function call #255

Merged
merged 2 commits into from
Nov 30, 2023
Merged

changed buffer add function call #255

merged 2 commits into from
Nov 30, 2023

Conversation

kim-mskw
Copy link
Contributor

changed buffer add function call to not only add the first value of the observations 50 times.

I am wondering how it learned anything with these observations in the buffer...

@kim-mskw kim-mskw self-assigned this Nov 29, 2023
@kim-mskw kim-mskw requested a review from nick-harder November 29, 2023 14:18
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bddb13) 78.44% compared to head (e18d165) 78.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files          39       39           
  Lines        4259     4259           
=======================================
  Hits         3341     3341           
  Misses        918      918           
Flag Coverage Δ
pytest 78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-harder
Copy link
Member

oh wow, that is weird error. I believe at some point observation contained past and future observations, so this was required. But at some point we probably shifted to use only one observation since next one could be sampled easily, but this part stayed

@nick-harder nick-harder merged commit 5db9076 into main Nov 30, 2023
4 checks passed
@nick-harder nick-harder deleted the buffer-write-fixes branch November 30, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants