-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract Market with feed in policy and market premium #248
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 79.86% 78.53% -1.33%
==========================================
Files 41 42 +1
Lines 4704 4916 +212
==========================================
+ Hits 3757 3861 +104
- Misses 947 1055 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@maurerle why do you believe the feed-in premium should be handled by an extra demand agent, ant not an additional market party? |
ce7a20f
to
be2bd63
Compare
61dc0f1
to
49b8941
Compare
@maurerle is this now ready? |
I'd still like to add some tests - but I don't think that I find time this week. |
@maurerle there is also no description of the new methods, no docstrings, and any mention of the new clearings in the documentation. It would be helpful to have them. Let's merge when tests and documentation are there, it can wait :-) |
c8aa54d
to
552e5d6
Compare
* supports market_premium * PPA * CfD
add small script to create policy scenario from scratch
bool: True if agent fulfills requirements | ||
""" | ||
if self.limitation: | ||
if self.limitation == "only_co2emissionless": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could make these technologies as a part of the config instead of hard coding them at this spot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to improve this once we have more than 2 possible limitations of market participants.
What do you mean with "part of the config"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since now we have additional configs for each market, we could list such technologies there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
But I don't know if this will only stay "a list of allowed technologies" - one could also specifiy to limit this market to agents with a max_power > 10MW or whatever - so I would like to keep this loose for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments
This PR implements a feed in policy, which calculates the value a special demand agent pays on top of the market prices as a feed-in-tariff.
The contract is accepted on a monthly base for example, and evaluated on a weekly base.
For this, the generation and market_price of the last week is requested using the data_request mechanism developed in #247 - then the resulting orderbook is created and sent to the contract participants using the already existing
clearing
process.This works in general, though the results are not correct yet. I think the volume and price is applied for the whole series and the dashboard needs some polishment too.