-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RL Doku Proposal #221
RL Doku Proposal #221
Conversation
…ph for the provided exampels and uploaded the workshop examples as proper examples in the folder.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 39 39
Lines 4076 4076
=======================================
Hits 3276 3276
Misses 800 800
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think that this is in general very good and helpful! I added the new files to the index, so that you can find them in the navigation on the left on the docs page using: You might want to convert your docs using a Markdown to RST conversion tool. Other OS's than Windows care about capitalization in file names, so I fixed that too :) |
I did change the format hopefullz in the right waz. I, however, have problems buidling the docs. The port seems not reachable somehow. Does it work for someone else or did I break something? Also I add github badges that link the colab tutorials. |
Sooo, I think I fixed everything :) please review the changes, as we should push the draft before the workshop tomorrow, and ideally we should add the description of the other example files as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Btw @kim-mskw after you have run the make command - you can run: Maybe something is already running on port 8000 on your machine 🤷 |
Made a first suggestion for a learning dokumentation. Added a paragraph for the provided exampels and uploaded the workshop examples as proper examples in the folder.
I copied something together. it definitely needs some work, but I wanted you feedback on the general idea first, before I finish it up. What do you guys think?