Adressing some major issues with learning #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 82.02% 81.94% -0.08%
==========================================
Files 39 39
Lines 4056 4055 -1
==========================================
- Hits 3327 3323 -4
- Misses 729 732 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
maurerle
reviewed
Sep 27, 2023
There was a problem hiding this comment.
We should address the generated issue in the clearing in a proper way to still add the leftover, everytime we have enough demand/supply.
Having the same amount of orders as submitted is also an open request for clearing improvements from #133
Other than that it looks good!
maurerle
force-pushed
the
fix-learning-strategies
branch
2 times, most recently
from
d33d624 to
a0d1a09
Compare
maurerle
approved these changes
Sep 28, 2023
-fixed saving learned strategies -fixes profit and regret calculations -fixed missing unit_id in rejected orders -fixed issue when mcp is tensor -fixed some dashboards -fixed use of variable cost while inputs use fixed cost -added check if learning is on but no RL strategies are given -query for evarge reward in eval raises an error if not available -update dashboard
maurerle
force-pushed
the
fix-learning-strategies
branch
from
a0d1a09 to
5f1b792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fixed evaluation average reward calculation
-fixed saving learned strategies
-fixes profit and regret calculations
-fixed missing unit_id in rejected orders
-fixed issue when mcp is tensor
-fixed some dashboards
-fixed use of variable cost while inputs use fixed cost -added check if learning is on but no RL strategies are given -query for evarge reward in eval raises an error if not available