Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outputs function #208

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Fix outputs function #208

merged 6 commits into from
Sep 26, 2023

Conversation

nick-harder
Copy link
Member

-rl params were not written when not in learning
-should be for eval
-error handling was wrong

assume/common/units_operator.py Show resolved Hide resolved
assume/common/outputs.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e913958) 80.95% compared to head (5c438a4) 80.91%.

❗ Current head 5c438a4 differs from pull request most recent head 21fbf38. Consider uploading reports for the commit 21fbf38 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   80.95%   80.91%   -0.04%     
==========================================
  Files          40       40              
  Lines        4054     4056       +2     
==========================================
  Hits         3282     3282              
- Misses        772      774       +2     
Flag Coverage Δ
pytest 80.91% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
assume/common/units_operator.py 91.35% <ø> (ø)
assume/world.py 83.42% <ø> (ø)
assume/common/outputs.py 81.05% <0.00%> (-0.87%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

-catch other exceptions in outputs
assume/common/outputs.py Outdated Show resolved Hide resolved
Co-authored-by: Florian Maurer <[email protected]>
@nick-harder nick-harder merged commit ac75b59 into main Sep 26, 2023
2 checks passed
@nick-harder nick-harder deleted the fix-outputs-function branch September 26, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants