-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct cost calculations and storage operation #206
Conversation
This looks good! Is the storage now operating as expected? this fixes #197 right? |
…o cost-calculation-corrections
…ume-framework/assume into cost-calculation-corrections
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 80.89% 81.94% +1.05%
==========================================
Files 40 39 -1
Lines 4057 4044 -13
==========================================
+ Hits 3282 3314 +32
+ Misses 775 730 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
8cd845f
to
62b3b0b
Compare
62b3b0b
to
05ff19e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
This commit adapts the use of the right price forecast for storages, the cost calculations in flexable.py according to flexABLE (minor correction and inclusion of avg_operation_times) and the calculation of total_costs as reward_function