Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cost calculations and storage operation #206

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

adamsjohanna
Copy link
Contributor

This commit adapts the use of the right price forecast for storages, the cost calculations in flexable.py according to flexABLE (minor correction and inclusion of avg_operation_times) and the calculation of total_costs as reward_function

@adamsjohanna adamsjohanna requested review from nick-harder and removed request for nick-harder September 25, 2023 15:10
@maurerle
Copy link
Member

maurerle commented Sep 25, 2023

This looks good! Is the storage now operating as expected?
Hopefully, we are not breaking any other time assumptions through this :)
Maybe you can run some other examples just to be sure..?

this fixes #197 right?

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (ac75b59) 80.89% compared to head (5ef1b48) 81.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   80.89%   81.94%   +1.05%     
==========================================
  Files          40       39       -1     
  Lines        4057     4044      -13     
==========================================
+ Hits         3282     3314      +32     
+ Misses        775      730      -45     
Flag Coverage Δ
pytest 81.94% <55.55%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
assume/common/forecasts.py 85.36% <100.00%> (-1.63%) ⬇️
assume/common/units_operator.py 90.90% <100.00%> (-0.45%) ⬇️
...me/markets/clearing_algorithms/complex_clearing.py 90.78% <ø> (ø)
assume/strategies/dmas_powerplant.py 69.94% <100.00%> (ø)
assume/strategies/dmas_storage.py 82.03% <100.00%> (ø)
assume/strategies/learning_strategies.py 95.04% <100.00%> (ø)
assume/units/demand.py 100.00% <100.00%> (ø)
assume/units/powerplant.py 91.86% <92.30%> (+4.95%) ⬆️
assume/units/storage.py 88.80% <81.25%> (+2.99%) ⬆️
assume/strategies/flexable_storage.py 86.98% <65.85%> (-8.89%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsjohanna adamsjohanna force-pushed the cost-calculation-corrections branch from 8cd845f to 62b3b0b Compare September 26, 2023 13:33
@adamsjohanna adamsjohanna force-pushed the cost-calculation-corrections branch from 62b3b0b to 05ff19e Compare September 26, 2023 13:56
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nick-harder nick-harder merged commit fa9e9b3 into main Sep 27, 2023
3 of 4 checks passed
@nick-harder nick-harder deleted the cost-calculation-corrections branch September 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants