-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable writing data during learning process #205
Conversation
-adjusted learning dashboard
@maurerle I have also adjusted the learning dashboard, but I couldn't get the last two graphs to work - Bid price and bid volume, and also the noise. Could you pleae take a look at them? Ideally the bids ones should display all bids submitted by the learning agent. Thanks! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 80.90% 80.97% +0.07%
==========================================
Files 40 40
Lines 4058 4052 -6
==========================================
- Hits 3283 3281 -2
+ Misses 775 771 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would find it much better, if we split this up by
output_agent_addr
and
learning_output_agent_addr
in the data_dict
As we are already checking if a output_agent_id and addr is given, we can use this to distinguish if we should write..?
then we can set this in world, that market and units operator do not have an output agent and units_operator only knows a learning_output_agent
- therefore writes only learning..?
I can prepare a draft for this if this is unclear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that's also great to not hardcode the learning_agent!
I just meant to provide the output agent twice with a different param, as it is used in a different context (writing learning output instead of other output)
-fixing adresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you!
-no more outputs written when learning
-adjusted learning dashboard