Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable writing data during learning process #205

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

nick-harder
Copy link
Member

-no more outputs written when learning
-adjusted learning dashboard

-adjusted learning dashboard
@nick-harder
Copy link
Member Author

@maurerle I have also adjusted the learning dashboard, but I couldn't get the last two graphs to work - Bid price and bid volume, and also the noise. Could you pleae take a look at them? Ideally the bids ones should display all bids submitted by the learning agent. Thanks!

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.07% 🎉

Comparison is base (5d9234d) 80.90% compared to head (157be69) 80.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   80.90%   80.97%   +0.07%     
==========================================
  Files          40       40              
  Lines        4058     4052       -6     
==========================================
- Hits         3283     3281       -2     
+ Misses        775      771       -4     
Flag Coverage Δ
pytest 80.97% <93.54%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
assume/common/outputs.py 82.25% <87.50%> (+0.71%) ⬆️
assume/common/units_operator.py 91.35% <100.00%> (+0.54%) ⬆️
assume/markets/base_market.py 89.44% <100.00%> (ø)
assume/world.py 83.42% <100.00%> (+0.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find it much better, if we split this up by
output_agent_addr and
learning_output_agent_addr in the data_dict

As we are already checking if a output_agent_id and addr is given, we can use this to distinguish if we should write..?

then we can set this in world, that market and units operator do not have an output agent and units_operator only knows a learning_output_agent - therefore writes only learning..?
I can prepare a draft for this if this is unclear?

assume/common/outputs.py Outdated Show resolved Hide resolved
assume/common/outputs.py Outdated Show resolved Hide resolved
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's also great to not hardcode the learning_agent!
I just meant to provide the output agent twice with a different param, as it is used in a different context (writing learning output instead of other output)

assume/common/units_operator.py Outdated Show resolved Hide resolved
assume/common/units_operator.py Outdated Show resolved Hide resolved
assume/common/units_operator.py Outdated Show resolved Hide resolved
assume/common/units_operator.py Show resolved Hide resolved
assume/world.py Outdated Show resolved Hide resolved
-fixing adresses
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you!

@maurerle maurerle changed the title Disable writing a ton of data during learning process Disable writing data during learning process Sep 25, 2023
@maurerle maurerle merged commit caabadb into main Sep 25, 2023
4 checks passed
@maurerle maurerle deleted the disable-writing-when-learning branch September 25, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants