allow running simulation without port assignment #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-harder
approved these changes
Sep 25, 2023
|
@maurerle failing |
maurerle
force-pushed
the
no_port
branch
2 times, most recently
from
1990b25 to
8cb1c6a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 80.95% 80.90% -0.06%
==========================================
Files 40 40
Lines 4053 4058 +5
==========================================
+ Hits 3281 3283 +2
- Misses 772 775 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #202 by using the external_connection Container, which does not require a port.
Until https://gitlab.com/mango-agents/mango/-/merge_requests/91 is merged and released, we therefore need to switch to mango-agents from gitlab